Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add buffer #58

Merged
merged 2 commits into from
Jun 26, 2020
Merged

fix: add buffer #58

merged 2 commits into from
Jun 26, 2020

Conversation

hugomrdias
Copy link
Contributor

This PR adds buffer as a dependency so we don't need to rely on browser bundlers injection.

lib/encodings.js Outdated Show resolved Hide resolved
@juliangruber
Copy link
Member

in general +1 if this makes bundling level* easier

@vweevers
Copy link
Member

This moves the burden - of keeping buffer versions in sync across modules - from the bundler to module maintainers. That's fine, buffer doesn't change that often.

Some folks (that only use level modules in node) are not happy with additional dependencies. That's OK, because abstract-leveldown already has the buffer dependency.

I'm still on the fence regarding the webpack change, but that's due to the nextTick story (see discussions in readable-stream) rather than buffer. I do wonder, because we learned that webpack's ideals aren't realistic (which very much applies to the level ecosystem due to its heavy use of streams), whether it's wise to nevertheless continue chasing those ideals. Ultimately a webpack user will still have to inject nextTick.

@vweevers vweevers merged commit d6be99c into Level:master Jun 26, 2020
@vweevers
Copy link
Member

9.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants