Proper destroy #34
Proper destroy #34
Conversation
| this._iterator.end(function (err2) { | ||
| callback(err || err2) | ||
|
|
||
| // TODO when the next readable-stream (mirroring node v10) is out: |
There was a problem hiding this comment.
Cool. Didn't know about this.
| stream.on('close', onClose) | ||
| } | ||
|
|
||
| return order |
test.js
Outdated
| }) | ||
|
|
||
| iterator.next = function (cb) { | ||
| cb(new Error('next')) |
There was a problem hiding this comment.
Maybe do process.nextTick(cb, new Error('next'))? (Assuming we only run tests in node that is)
|
@ralphtheninja wait, what about this? |
Sorry for being sloppy. I'll fix. |
|
Np. I guess these could be considered fixes (because we're now api-compatible with streams):
But I'm not sure about:
|
|
Geesh I'm messing things up today. So, to be sure, I could release |
|
I don't really have energy left to think about this, but reverting sounds comforting ;) |
This reverts commit 9460d1b.
next()error (closes Call destroy() on next() error #33)closeaftererror(mimicking node 10) (before this PR,errorwas the last event).destroy(err)(node 8).destroy(err, callback)(node 8).