Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.1.1 #605

Merged
merged 3 commits into from
Jul 14, 2018
Merged

Prepare 3.1.1 #605

merged 3 commits into from
Jul 14, 2018

Conversation

ralphtheninja
Copy link
Member

No description provided.

@vweevers
Copy link
Member

Test

@vweevers
Copy link
Member

GH is having problems, doesn't allow posting comments on the diff. So I'll do it here:

  • Are we sure the level-iterator-stream upgrade is safe to include in a patch?
  • Can you add my name to the airtap upgrade?
  • The "Call rs.destroy() without .." should be under Fixed

@ralphtheninja
Copy link
Member Author

Are we sure the level-iterator-stream upgrade is safe to include in a patch?

Is Level/iterator-stream#34 a breaking change?

@vweevers
Copy link
Member

I thought about Level/iterator-stream#34 (comment) for a minute and I think we're good. When an error occurs, we now emit error and close. Before it was only error. Because the new event is emitted after the existing event, it's unlikely to break existing flows, which probably stop after an error anyway. More importantly, nothing happens between error and close. When we emit error, we've already cleaned up (ended the iterator).

@ralphtheninja
Copy link
Member Author

@vweevers I have pushed an update but it doesn't show in GH yet.

@vweevers
Copy link
Member

I have pushed an update but it doesn't show in GH yet.

I checked it out locally, LGTM! I assume you'll update the Unreleased header before publish?

@ralphtheninja
Copy link
Member Author

I checked it out locally, LGTM! I assume you'll update the Unreleased header before publish?

Should I be honest? 😉 Just too tired and making mistakes all the time. Will update!

@ralphtheninja ralphtheninja merged commit 38c6e95 into master Jul 14, 2018
@ralphtheninja ralphtheninja deleted the prepare-3.1.1 branch July 14, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants