Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create test for createReadStream error while closing the db #370

Closed
ralphtheninja opened this issue Jun 8, 2017 · 3 comments
Closed

create test for createReadStream error while closing the db #370

ralphtheninja opened this issue Jun 8, 2017 · 3 comments
Labels
test Improvements or additions to tests

Comments

@ralphtheninja
Copy link
Member

See #37 and #37 (comment) for background
@vweevers
Copy link
Member

vweevers commented Jun 8, 2017

@ralphtheninja woa you've been a busy bee :)

@ralphtheninja
Copy link
Member Author

:trollface:

@vweevers vweevers added the test Improvements or additions to tests label Dec 31, 2018
@vweevers
Copy link
Member

This is covered now, by the combination of #514, #597, #612 and Level/iterator-stream#34 (the latter ensures the iterator is ended on an error, the former ensure that closing the db waits for pending operations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphtheninja @vweevers