-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and document native order #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
force-pushed
the
fixed-native-order
branch
from
December 27, 2018 12:26
1361ad1
to
2ee292d
Compare
vweevers
changed the title
Test and document native order [wip]
Test and document native order
Dec 27, 2018
```js | ||
const db = levelup(leveljs('time-db')) | ||
|
||
db.createReadStream({ gt: new Date('2019-01-01') }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool!
```js | ||
const db = levelup(leveljs('books-db')) | ||
|
||
await db.put(['Roald Dahl', 'Charlie and the Chocolate Factory'], {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also really cool! :)
ralphtheninja
approved these changes
Dec 27, 2018
Tests failed on what seems like an unrelated race issue (or conflict between tests, idk): Click to expand
|
Restarted the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156. Reverts the temporary workaround introduced in #155.
Tested locally in Chrome, FF, Opera, IE and Edge.
Stumbled upon a curious bug in IE and Edge: if the database contains any key types other than string, then
{ gte: '' }
yields 0 results. I've disabled the relevant test by commenting it out.