Prevent segfaults: defer closing until all operations are done #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
peakji
approved these changes
Apr 23, 2019
| }) | ||
|
|
||
| // Test multiple pending operations, using all of the above. | ||
| testPending('operations', operations.length, function (db, next) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32. Follow-up to #597.
I made sure to replicate a segfault (or a failed LevelDB assertion in the case of
get()) for each operation before fixing it. That required repeating the tests a few thousand times with a forloop; I didn't keep that code because it would make CI runs too long. I wasn't able to replicate a segfault forapproximateSize()but I'm confident enough in the basic mechanism to let that slide. Lastly,compactRange()did not segfault either but it did hang, so that's fixed now too.