add a note on upgrading to 3.0.1+ if running node 10 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't you say 2.0.2 and above work on node 10? |
|
@vweevers Technically, it compiles, but we don't have any prebuilt binaries for node 10 on those versions. |
|
Maybe we should clarify this as well. |
vweevers
reviewed
May 15, 2018
UPGRADING.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| This document describes breaking changes and how to upgrade. For a complete list of changes including minor and patch releases, please refer to the [changelog](CHANGELOG.md). | |||
|
|
|||
| ## v3.0.1 | |||
|
|
|||
| If you're running node v10 or above you need to upgrade to `leveldown@2.0.1` or above. In addition, if you need prebuilt binaries you should upgrade to `leveldown@3.0.1` or above. | |||
There was a problem hiding this comment.
I prefer "you'll need X" over "you need to X". And "or above" is implied, can be left out I think. But if you change it to "at least X to successfully compile" it becomes a subtle way to nudge people towards v3 :)
If you're running node v10 you'll need at least
leveldown@2.0.1to successfully compile from source. For prebuilt binaries please upgrade toleveldown@3.0.1.
vweevers
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #458