Upgrade nan, prebuild(-install), add node 11 #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: GitHub's Draft feature is awesome. Let's get rid of the WIP app? |
@vweevers I don't know how the draft feature work, but if you like it, do it 😄 |
ralphtheninja
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can publish this as 4.0.2. The
nanupgrade might fix compilation for Mac users, pending feedback on #595 (comment).In case it doesn't, the
prebuildandprebuild-installupgrade (incorporating prebuild/prebuild#234) means we can at least publish prebuilds for node 11.If that doesn't work, then let's just get v5 out the door 😄