Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memdown Sync #50

Closed
wants to merge 2 commits into from
Closed

Memdown Sync #50

wants to merge 2 commits into from

Conversation

ccorcos
Copy link

@ccorcos ccorcos commented Feb 28, 2019

Making levelup work synchronously is going to involve a ton of work.

Level/leveldown#372

Instead, I've simply patched over a few files and compiled it all into a single file using ncc and it works!

@vweevers
Copy link
Member

I'm very much opposed to this solution (monkeypatching, having compiled code, maintaining this when APIs change) which will cost us time in the long run, so I rather we do it properly from the start.

@ccorcos
Copy link
Author

ccorcos commented Mar 4, 2019

I totally agree. Just wanted to leave this here for anyone else looking for a solution. It was a fun challenge for me ;)

I would also mention that createReadStream doesn't work with this solution. Ideally the streaming api would just use an IterableIterator and AsyncIterableIterator instead of the stream.

Right now I'm just creating my own abstraction around memdown and that's a lot easier. I have to do the encodings myself though.

@ccorcos ccorcos closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants