-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sys/sysmacros.h for build on modern glibc #86
Conversation
Thanks for your contribution and welcome! This will become obsolete, because we're moving RocksDB to a git submodule (#82). |
Excellent, that is a better fix for sure. I needed this change to begin using rocksdb right away, so I figured I would offer a pull as well. |
Might as well merge this for now. We'd also need to find a more recent version of RocksDB with |
Roger. We can considering merging this, because #82 isn't ready yet and afterwards we'd also need to update RocksDB to a more recent version. @ralphtheninja WDYT? |
@filoozom beat me to it :) |
Looks like you're lucky, this commit is really old: facebook/rocksdb@3b4d1b7. Shouldn't be a problem to update to there once the time has come to merge the Git Submodule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream's PR: facebook/rocksdb#2208
Released in 3.0.3 |
Port of https://github.com/facebook/rocksdb/pull/2208/files
Without this,
npm i rocksdb
fails on my arch linux machine.glibc version:
Error: