Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated example #44

Closed
wants to merge 1 commit into from
Closed

Update outdated example #44

wants to merge 1 commit into from

Conversation

ralphtheninja
Copy link
Member

@ralphtheninja ralphtheninja commented Jun 1, 2018 •
edited
Loading

Closes #41

vweevers
vweevers reviewed Jun 2, 2018
View reviewed changes
example.js

var test = sub(db, 'test', {valueEncoding: 'utf-8', separator: '@'})
var test2 = sub(test, 'tester', {valueEncoding: 'utf-8', separator: '@'})
var test = sub(db, 'test', { valueEncoding: 'utf-8', separator: '@' })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • utf-8 => utf8
  • that's the default encoding though, maybe use json instead (esp. because the example puts an array value)
  • would leave out the separator option, keep it simple.
  • on that subject, the example is too long. Shouldn't need 3 puts, 3 gets and a read stream to demonstrate the basics.
  • IMO we can remove example.js altogether.

@ralphtheninja ralphtheninja deleted the update-example branch June 2, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers