-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor open() and close() to mostly bypass levelup #79
Conversation
To simplify, maybe we should say that a user must manage the open state of a db outside of subleveldown. Meaning:
|
This comment has been minimized.
This comment has been minimized.
😆 |
cbd6b9a
to
5119ac0
Compare
This comment has been minimized.
This comment has been minimized.
…bstract-leveldown < 2.4.0
0033a71
to
a69ba5d
Compare
Alternative strategy:
|
In other words, the input db must open itself (or once closed by the user, be explicitly reopened by the user) because sublevels shouldn't concern themselves with (the state of) the rest of the db. Closing this PR, I don't like it. Will explore the alternative strategy. |
Closes #60, closes #77, closes #78, and opens up the possibility to add a manifest.
I was sitting around thinking "how can i make subleveldown more complicated" and this PR is the result.