Implement full support for E5M2, and decoding for E4M3 #22
Annotations
15 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run HLint:
src/CrackNum/Main.hs#L166
Suggestion in getFP in module Main: Use otherwise ▫︎ Found: "mkEBSB eb sb\n | eb >= 2 && eb <= 29 && sb >= 2 && sb <= 1073741822\n = Floating $ FP eb sb\n | True\n = BadFlag\n [\"Invalid floating-point precision.\", \"\",\n \" Exponent size must be between \"\n ++ show (2 :: Int) ++ \" to \" ++ show (29 :: Int),\n \" Significant size must be between \"\n ++ show (2 :: Int) ++ \" to \" ++ show (1073741822 :: Int),\n \"\", \"Received: \" ++ show eb ++ \" \" ++ show sb]" ▫︎ Perhaps: "mkEBSB eb sb\n | eb >= 2 && eb <= 29 && sb >= 2 && sb <= 1073741822\n = Floating $ FP eb sb\n | otherwise\n = BadFlag\n [\"Invalid floating-point precision.\", \"\",\n \" Exponent size must be between \"\n ++ show (2 :: Int) ++ \" to \" ++ show (29 :: Int),\n \" Significant size must be between \"\n ++ show (2 :: Int) ++ \" to \" ++ show (1073741822 :: Int),\n \"\", \"Received: \" ++ show eb ++ \" \" ++ show sb]"
|
|
Run HLint:
src/CrackNum/Main.hs#L279
Suggestion in crack in module Main: Use otherwise ▫︎ Found: "inferLanes prefix\n | prefix `rem` eSize == 0 = pure $ Just (prefix `div` eSize)\n | True\n = die\n [\"Verilog notation size mismatch:\",\n \" Input length: \" ++ show prefix,\n \" Element size: \" ++ show eSize,\n \"Length must be an exact multiple of the element size.\"]" ▫︎ Perhaps: "inferLanes prefix\n | prefix `rem` eSize == 0 = pure $ Just (prefix `div` eSize)\n | otherwise\n = die\n [\"Verilog notation size mismatch:\",\n \" Input length: \" ++ show prefix,\n \" Element size: \" ++ show eSize,\n \"Length must be an exact multiple of the element size.\"]"
|
|
Run HLint:
src/CrackNum/Main.hs#L295
Suggestion in crack in module Main: Use otherwise ▫︎ Found: "lanes\n | tryInfer = fromMaybe lanesGiven lanesInferred\n | True = lanesGiven" ▫︎ Perhaps: "lanes\n | tryInfer = fromMaybe lanesGiven lanesInferred\n | otherwise = lanesGiven"
|
|
Run HLint:
src/CrackNum/Main.hs#L313
Suggestion in decodeAllLanes in module Main: Use otherwise ▫︎ Found: "header i\n | lanes == 1 = pure ()\n | True = putStrLn $ \"== Lane \" ++ show i ++ \" \" ++ replicate 60 '='" ▫︎ Perhaps: "header i\n | lanes == 1 = pure ()\n | otherwise\n = putStrLn $ \"== Lane \" ++ show i ++ \" \" ++ replicate 60 '='"
|
|
Run HLint:
src/CrackNum/Main.hs#L374
Suggestion in parseToBits in module Main: Use otherwise ▫︎ Found: "cvt i\n | isHex = concat <$> mapM cvtHex i\n | True = concat <$> mapM cvtBin i" ▫︎ Perhaps: "cvt i\n | isHex = concat <$> mapM cvtHex i\n | otherwise = concat <$> mapM cvtBin i"
|
|
Run HLint:
src/CrackNum/Main.hs#L453
Warning in decodeLane in module Main: Redundant bracket ▫︎ Found: "(Satisfiable {})" ▫︎ Perhaps: "Satisfiable {}"
|
|
Run HLint:
src/CrackNum/Main.hs#L461
Warning in de5m2 in module Main: Redundant bracket ▫︎ Found: "(Satisfiable {})" ▫︎ Perhaps: "Satisfiable {}"
|
|
Run HLint:
src/CrackNum/Main.hs#L461
Warning in de5m2 in module Main: Fuse mapM_/map ▫︎ Found: "mapM_ putStrLn $ map fixType (lines (show res))" ▫︎ Perhaps: "mapM_ (putStrLn . fixType) (lines (show res))"
|
|
Run HLint:
src/CrackNum/Main.hs#L464
Suggestion in de5m2 in module Main: Use otherwise ▫︎ Found: "fixType s\n | \"DECODED\" `isInfixOf` s = takeWhile (/= ':') s ++ \":: E5M2\"\n | True = s" ▫︎ Perhaps: "fixType s\n | \"DECODED\" `isInfixOf` s = takeWhile (/= ':') s ++ \":: E5M2\"\n | otherwise = s"
|
|
Run HLint:
src/CrackNum/Main.hs#L478
Suggestion in de4m3Model in module Main: Use otherwise ▫︎ Found: "sval\n | sign = - val\n | True = val" ▫︎ Perhaps: "sval\n | sign = - val\n | otherwise = val"
|
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Set up HLint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The logs for this run have expired and are no longer available.
Loading