Skip to content

Commit

Permalink
Fix Windows sign (#316)
Browse files Browse the repository at this point in the history
  • Loading branch information
Levminer authored Aug 30, 2024
1 parent dfdf7b0 commit 97a3aa5
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 25 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/release-artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Install trusted-signing-cli
if: matrix.NAME == 'windows'
run: |
cargo install trusted-signing-cli@0.2.0
cargo install trusted-signing-cli@0.3.0
- name: "Apple silicon target"
if: runner.os == 'macOS'
Expand Down Expand Up @@ -97,10 +97,6 @@ jobs:
path: package.json
prop_path: version

- name: Sign windows installer
run: |
npm run sign ./core/target/release/upload/authme-${{steps.version.outputs.prop}}-windows-x64.msi
# Windows
- name: Upload the windows installer asset
if: runner.os == 'Windows'
Expand Down
8 changes: 1 addition & 7 deletions core/tauri.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"build": {
"beforeBuildCommand": "npm run build:bundle",
"beforeDevCommand": "npm run server",
"beforeBundleCommand": "npm run sign ./core/target/release/Authme.exe",
"devPath": "http://localhost:3000",
"distDir": "../dist"
},
Expand Down Expand Up @@ -41,12 +40,7 @@
},
"resources": [],
"shortDescription": "",
"targets": "all",
"windows": {
"certificateThumbprint": null,
"digestAlgorithm": "sha256",
"timestampUrl": ""
}
"targets": "all"
},
"security": {
"csp": "default-src blob: data: filesystem: ws: http: https: 'unsafe-eval' 'unsafe-inline' 'self' img-src: 'self'; script-src 'unsafe-eval'"
Expand Down
9 changes: 9 additions & 0 deletions core/tauri.windows.conf.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"tauri": {
"bundle": {
"windows": {
"signCommand": "trusted-signing-cli %1 -e https://wus2.codesigning.azure.net -a mnr -c Profile3"
}
}
}
}
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"setup": "node scripts/buildNumber.cjs alpha false && node scripts/build.js",
"rename": "node scripts/rename.js",
"check": "svelte-check && tsc --noEmit && eslint .",
"sign": "node scripts/sign.js",
"tauri": "tauri"
},
"workspaces": [
Expand Down
12 changes: 0 additions & 12 deletions scripts/sign.js

This file was deleted.

0 comments on commit 97a3aa5

Please sign in to comment.