Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement split cell mode #155

Merged
merged 47 commits into from
Jan 17, 2022
Merged

Implement split cell mode #155

merged 47 commits into from
Jan 17, 2022

Conversation

LewisGaul
Copy link
Owner

@LewisGaul LewisGaul commented Jan 10, 2022

Fixes #41

This supercedes #147 (and #148, which was accidentally closed).

  • Fix tests
  • Get chording working
  • Detect game being won
  • Add menubar button to switch mode
  • Disable highscores
  • Support creating boards in split-cell mode
  • Implement save board (store game mode) and make load board switch mode
  • Set 50% mine defaults for standard game sizes
  • Prevent custom boards with odd dimensions
  • Fix issues with drag-select flagging (also see Right-button drag on clicked cells in create mode doesn't work #128)
  • Calculate 3bv, remaining 3bv, ...
  • Make highscore settings take game mode into account when opening highscore window
  • Make sure difficulty radiobuttons are marked correctly
  • Look into performance (e.g. recalculating numbers, finding openings)
  • Check detecting game being won when all sub-cells contain mines but large cell isn't split
  • Ensure number of mines is zero when changing difficulty in create mode
  • Fix bug with switching modes with odd dimensions

@LewisGaul LewisGaul changed the title Add back in split cell code Implement split cell mode Jan 10, 2022
@LewisGaul LewisGaul mentioned this pull request Jan 10, 2022
7 tasks
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #155 (0e23374) into dev (4c1bf1a) will decrease coverage by 4.17%.
The diff coverage is 63.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #155      +/-   ##
==========================================
- Coverage   74.89%   70.71%   -4.18%     
==========================================
  Files          29       38       +9     
  Lines        3151     3719     +568     
==========================================
+ Hits         2360     2630     +270     
- Misses        791     1089     +298     
Impacted Files Coverage Δ
minegauler/core/split_cell/game.py 19.59% <19.59%> (ø)
minegauler/core/split_cell/minefield.py 24.00% <24.00%> (ø)
minegauler/core/split_cell/controller.py 31.64% <31.64%> (ø)
minegauler/core/engine.py 81.65% <32.14%> (-17.15%) ⬇️
minegauler/frontend/minefield/split_cell.py 36.95% <36.95%> (ø)
minegauler/shared/highscores.py 70.04% <42.85%> (-1.00%) ⬇️
minegauler/shared/utils.py 81.11% <50.00%> (-0.45%) ⬇️
minegauler/frontend/main_window.py 51.14% <52.77%> (+0.02%) ⬆️
minegauler/core/api.py 90.36% <70.58%> (-1.75%) ⬇️
minegauler/core/split_cell/types.py 73.91% <73.91%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1bf1a...0e23374. Read the comment docs.

@LewisGaul LewisGaul self-assigned this Jan 13, 2022
@LewisGaul LewisGaul marked this pull request as ready for review January 13, 2022 23:29
@LewisGaul LewisGaul merged commit 65f468a into dev Jan 17, 2022
@LewisGaul LewisGaul deleted the split-cells-coord-abstraction branch January 17, 2022 23:16
@LewisGaul LewisGaul linked an issue Jan 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'split cells' mode
1 participant