Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to CIE S 026 not correct for age-correction related to pupil size #11

Closed
DieterLa opened this issue Aug 29, 2023 · 2 comments
Closed
Assignees
Labels
question Further information is requested

Comments

@DieterLa
Copy link

Only DIN/TS 5031-100 defines an age-correction for reduced pupil diameter with age.
CIE S 026 doesn't define this.
For this correction, the reference should only cite DIN, but not CIE.

This applies on all results pages for age-corrected data

@JZauner JZauner self-assigned this Sep 15, 2023
@JZauner
Copy link
Collaborator

JZauner commented Sep 15, 2023

I guess this goes back to the previous issue #10 , just the other way around. Both DIN and CIE say that age correction should be considered, but only DIN provides the equation.
Right now, Spectran states that: "The equations for the age-related correction are taken from DIN/TS 5031-100:2021-11. The evaluation is further compliant with the CIE S026 (2018)."
This to me still makes sense, as when I apply the age-correction from DIN/TS, I comply with the requirement for age-correction from CIE, no?

@JZauner JZauner added the question Further information is requested label Sep 15, 2023
@JZauner
Copy link
Collaborator

JZauner commented Nov 3, 2023

Made the change. It will go online in Version 1.0.0 of Spectran

@JZauner JZauner closed this as completed Nov 3, 2023
JZauner added a commit that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants