Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide and inform user about units for data import mW/nm or W/nm #4

Closed
DieterLa opened this issue Aug 29, 2023 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@DieterLa
Copy link

The input assumes the data given in W/nm
Results are shown in mW/nm
This is not consistent
Best option would be allowing the user to decide about his data.
second best option is to inform the user about the required scaling in W/nm
Often data is saved in mW/nm

@JZauner
Copy link
Collaborator

JZauner commented Sep 15, 2023

Actually, the second sentence in the import/Upload section states that data needs to be in W/(m² * nm), so the second best option is already included.
Rescaling can be easily done in the Import Options. I think the easiest way to implement your best option would be to just make a little selection available there to state how the data is scaled. I can do that.

@JZauner JZauner self-assigned this Sep 15, 2023
@JZauner JZauner added enhancement New feature or request and removed enhancement New feature or request labels Sep 15, 2023
@JZauner
Copy link
Collaborator

JZauner commented Nov 3, 2023

I have added an option to set the import format to mW, to W, or to your own scale. It will go online in Version 1.0.0 of Spectran

@JZauner JZauner closed this as completed Nov 3, 2023
JZauner added a commit that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants