Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor differences for results of L-cone- and M-cone-opic data #9

Closed
DieterLa opened this issue Aug 29, 2023 · 2 comments
Closed

minor differences for results of L-cone- and M-cone-opic data #9

DieterLa opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@DieterLa
Copy link

with the example of a LED as defined in CIE 15, 4th ed. as LED B2 (warmwhite 3000 K)
my own results at 1000 lx:
melanopic 607,1 mW 457,7 lx
S-cone-opic 296,1 mW 362,3 lx
M-cone-opic 1173,9 mW 806,3 lx
L-cone-opic 1646,8 mW 1011,0 lx
rhodopic 782,2 mW 539,6 lx

Spectran results:
melanopic 607 mW 458 lx
S-cone-opic 296 mW 362 lx
M-cone-opic 1170 mW 806 lx
L-cone-opic 1650 mW 1010 lx
rhodopic 782 mW 540 lx

The differences are bigger than only rounding to 1.
It looks like rounding to the third relevant digit. E.g. 1646,8 to 1650.
This is not nice.

It fits with issue #5 about number of significant digits.

@JZauner
Copy link
Collaborator

JZauner commented Sep 15, 2023

You are correct, there is unwanted rounding going on. If you look at the excel export of the spectrum, my results show, e.g.,

1010,77791 L-cone-opic EDI and
1646,45614 L-cone-opic Irradiance

I did use the CIE LED B2 Spectrum provided to me by Christoph Schierz and scaled it to 1000 lx with the factor 683.0015478 lm/W. The results are not identical to your own, but they clearly show that Spectran should round differently.

I will change this.

CIE Standard Illuminant "LED": Blue stimulated 2_1_2023-09-15.xlsx

@JZauner JZauner self-assigned this Sep 15, 2023
@JZauner JZauner added the bug Something isn't working label Sep 15, 2023
@JZauner
Copy link
Collaborator

JZauner commented Nov 3, 2023

This bug was fixed. It will go online in Version 1.0.0 of Spectran

@JZauner JZauner closed this as completed Nov 3, 2023
JZauner added a commit that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants