Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of correct names for non-visual stimuli #3

Closed
DieterLa opened this issue Aug 29, 2023 · 6 comments
Closed

Use of correct names for non-visual stimuli #3

DieterLa opened this issue Aug 29, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@DieterLa
Copy link

The app is using the terms "chloropic", "cyanopic", "erythropic" for the cone-responses.
These terms are not as defined in CIE S 026.
Correct would be "S-cone-opic", "M-cone-opic", "L-cone-opic" as defined in chapter 3.1.
rhodopic and melanopic is correct.

There is a high risk of mixing up with the definitions in Lucas' paper "Measuring light in the melanopsin age", when using the above cited terms "chloropic" ...
Even the action spectra are slightly different, what can cause deviations of up to 10%.

Please use the correct wordings for the cone-responses and make sure to apply the correct action spectra as defined in CIE S 026

@DieterLa
Copy link
Author

in this context I would also drop abbreviations like for example EEDI for erythropic equivalent daylight illuminance.
The same for chloropic or cyanopic.
Other abbreviations not used in standards have already been applied by some people, e.g. MEEI for melanopic equivalent equi-energy illuminance. This could become too chaotic.
I would prefer to keep it clear as defined in CIE S 026.
L-cone-opic equivalent daylight illuminance or L-cone-opic EDI, maybe L-cone-EDI, but not L-EDI or too simplified abbreviations.

@JZauner
Copy link
Collaborator

JZauner commented Sep 15, 2023

Hi Dieter, thanks for all your input. Right now I´m going through them one by one for sorting, but I will only be able to address it once I jump back into programming in October.

Just to make it clear - Spectran uses the action spectra from the CIE S 026 toolbox.

As for the naming scheme - I´m a bit sad that the logic for the five types is all over the place (from pigment based naming to wavelength-sensitivity based naming), but I get where you are coming from in terms of consistency, so I will change this. Do you have suggestions for the German naming scheme? M-cone-opisch? M-Zapfen-opisch? Doesn´t exactly roll of the tongue...

@JZauner JZauner self-assigned this Sep 15, 2023
@JZauner JZauner added the enhancement New feature or request label Sep 15, 2023
@JZauner
Copy link
Collaborator

JZauner commented Sep 15, 2023

Maybe you can also weigh in on whether the abbreviation should be MEDI or mEDI. The latter of which I see commonly used, but I don´t see the point, because then why not write meDI?
In the CIE S 026 it is written with all small caps alpha-opic equivalent daylight (D65) illuminance. So, no help there. And it is not as if EDI are a thing outside the alpha-opic world, ist it?
What do you/would you prefer?

@DieterLa
Copy link
Author

DieterLa commented Sep 15, 2023 via email

@DieterLa
Copy link
Author

DieterLa commented Sep 15, 2023 via email

@JZauner
Copy link
Collaborator

JZauner commented Nov 3, 2023

Made the change. It will go online in Version 1.0.0 of Spectran

@JZauner JZauner closed this as completed Nov 3, 2023
JZauner added a commit that referenced this issue Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants