Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice overview shows same sum values for different clients #5

Closed
lwndp opened this issue Oct 1, 2022 · 10 comments
Closed

Invoice overview shows same sum values for different clients #5

lwndp opened this issue Oct 1, 2022 · 10 comments
Labels
bug Something isn't working
Milestone

Comments

@lwndp
Copy link

lwndp commented Oct 1, 2022

As initially outlined here: kimai/kimai#3562

Issue resolved when deactivating the plugin entirely (not just the 'small business' option in settings

@LiaraAlis
Copy link
Owner

This is already fixed in v1.0.1. Please update.

@LiaraAlis LiaraAlis added the bug Something isn't working label Oct 1, 2022
@LiaraAlis LiaraAlis added this to the v1.0.1 milestone Oct 1, 2022
@lwndp
Copy link
Author

lwndp commented Oct 1, 2022

Awesome! Thank you!

@LiaraAlis
Copy link
Owner

Thank you for using my plugin. I appreciate any feedback. 😊

@lwndp
Copy link
Author

lwndp commented Oct 1, 2022

The invoice preview, overview section (at the bottom), still doesn't seem to show correct projects and related total hours. Only the total sum is now correct per client. Can you confirm this on your end?

I think this issue should be opened again.

@LiaraAlis LiaraAlis reopened this Oct 2, 2022
@LiaraAlis
Copy link
Owner

You're totally right, I didn't noticed that the listed projects doesn't match the customer.
This is a very strange problem. I have a look on this.

@LiaraAlis
Copy link
Owner

@lwndp Can you please try to checkout the master branch and test my changes in commit c363683?
I hope that these changes fixes the problem. To be honest, I have not yet really understood the cause of this issue…

If everything works well, I will release a new version.

@lwndp
Copy link
Author

lwndp commented Oct 3, 2022

@LiaraAlis your fix seems to have resolved the issue. Only thing I'd like to note is that the directory containing your plugin is called kimai2-SmallBusinessBundle and thus doesn't load into the kimai cache. I guess there is some sort of name validation going on. I had to rename it to "SmallBusinessBundle" for it to show up / work.

@lwndp lwndp closed this as completed Oct 3, 2022
@LiaraAlis
Copy link
Owner

@lwndp This is because this repository is named "kimai2-SmallBusinessRuleBundle". Because of that, you have to specify the target directory when using git clone. See here: https://github.com/LiaraAlis/kimai2-SmallBusinessRuleBundle#installation

@LiaraAlis
Copy link
Owner

@lwndp
Copy link
Author

lwndp commented Oct 3, 2022

My bad, sorry for not reading all the was to the right 😅
Thanks for the quick response and fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants