Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Vanilla Base Price #28

Merged
merged 6 commits into from
Aug 2, 2019
Merged

Stabilize Vanilla Base Price #28

merged 6 commits into from
Aug 2, 2019

Conversation

Libbum
Copy link
Owner

@Libbum Libbum commented Aug 2, 2019

Closes #27 when complete

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   88.92%   88.91%   -0.02%     
==========================================
  Files          14       14              
  Lines         840      839       -1     
==========================================
- Hits          747      746       -1     
  Misses         93       93
Impacted Files Coverage Δ
src/2013RVanilla.jl 100% <100%> (ø) ⬆️
src/ScenariosVanilla.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77d321...d8f56eb. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #28 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   88.92%   88.99%   +0.06%     
==========================================
  Files          14       14              
  Lines         840      845       +5     
==========================================
+ Hits          747      752       +5     
  Misses         93       93
Impacted Files Coverage Δ
src/ScenariosVanilla.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77d321...dede9be. Read the comment docs.

@Libbum Libbum changed the title [WIP] Stabilize Vanilla Base Price Stabilize Vanilla Base Price Aug 2, 2019
@Libbum
Copy link
Owner Author

Libbum commented Aug 2, 2019

In the end this was relatively simple: we just needed to fix the upperbound of cprice regardless of scenario.

@Libbum Libbum merged commit 40c9d09 into master Aug 2, 2019
@Libbum Libbum deleted the v2013RVbasefix branch August 2, 2019 14:03
This was referenced Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2013R Vanilla Base Price is not aligned
1 participant