Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging/balsam File Not Found Travis bug #244

Merged
merged 9 commits into from
Sep 12, 2019
Merged

Conversation

jlnav
Copy link
Member

@jlnav jlnav commented Sep 11, 2019

There's currently a very intermittent and hard-to-reproduce bug with test_balsam_hworld.py that only occurs on Travis. This PR doesn't resolve that bug, but takes some steps towards narrowing down the source of the issue.

I encourage anyone working on feature branches to merge in these changes and let me know when another test_balsam_hworld failure occurs. Thank you!

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 94.249% when pulling 4cc5610 on debugging/balsam_no-file into 3626625 on develop.

Copy link
Member

@jmlarson1 jmlarson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but I'd let @shuds13 vote too.

Copy link
Member

@shuds13 shuds13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shuds13 shuds13 merged commit 1b7f754 into develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants