Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tf>=2.0 enhanced with NMT with attention. #50

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

ashutosh16399
Copy link
Contributor

Hi, please review and merge.

@mommi84 mommi84 self-requested a review March 26, 2021 12:30
Copy link
Member

@mommi84 mommi84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. In the future, I would like to make the EPOCHS constant in train.py a parameter that the user can set via command line.

Please restore the following missing files by pushing them to the en_NspM branch.

.gitignore
LICENSE
analyse.py
generator_test.py
split_in_train_dev_test.py

@ashutosh16399
Copy link
Contributor Author

Hi, @mommi84
analyse.py
generator_test.py
split_in_train_dev_test.py
i saw these files, currently, they are not included in the pipeline, I will add these files for now and include them later in the pipeline as well.

@mommi84 mommi84 changed the title update tf>=2.0 enhanced with NMT with attention. Update to tf>=2.0 enhanced with NMT with attention. Mar 29, 2021
@mommi84 mommi84 merged commit fd98a16 into LiberAI:master Mar 29, 2021
ashutosh16399 pushed a commit to ashutosh16399/NSpM that referenced this pull request May 24, 2021
Update to tf>=2.0 enhanced with NMT with attention.
This was referenced Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants