Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a grid item hover that works for smaller sizes #998

Closed
rstorey opened this issue May 22, 2019 · 1 comment
Closed

Make a grid item hover that works for smaller sizes #998

rstorey opened this issue May 22, 2019 · 1 comment
Assignees
@klee72 @jbresner
Labels
Activity UI

Comments

@rstorey
Copy link
Member

rstorey commented May 22, 2019

  • Make an asset hover display that works when asset list is in film strip column

Based on the way the sizes are contained in the list, I suspect the answer is either going to be ruthlessly truncating the amount of information or changing it to be position:absolute so it can be larger than the containing element, but that will require a bit of code (maybe just reusing the Bootstrap popover we're already using in other places?) to update it when the list position changes.

I think Bootstrap popover is the better option (left direction) as 'position: absolute' would look little wonky no matter how we place it. Another solution I can think of is that we could just rely on title attribute and hide the .asset-tooltip on edit view.

Originally posted by @klee72 in #930 (comment)

Ki also noted that the same problem occurs when using smaller thumbnail sizes in the Browse All grid view.
@elainekamlley elainekamlley mentioned this issue May 22, 2019
Closed
29 tasks
acdha added a commit that referenced this issue May 23, 2019
@acdha
Basic Popper.js re-implementation of asset tooltips
a07e0cf 
This attempts to display the tooltip to the left of the current asset, but Popper.js is smart enough not to fix it there if that would keep it offscreen. 

There’s just enough CSS to add a border — this could probably use some additional TLC for more distinct colors and we probably want to adjust widths and font sizes, too.

See #998
@acdha acdha mentioned this issue May 23, 2019
Merged
klee72 added a commit that referenced this issue Jun 3, 2019
@klee72
#998 Restyled grid hover text container
9e09a0f
klee72 added a commit that referenced this issue Jun 3, 2019
@klee72
#998
ea2d496
rstorey added a commit that referenced this issue Jun 3, 2019
@rstorey
Merge pull request #1045 from LibraryOfCongress/activity-ui-prototype
e4eccdf 
#998 Restyled grid hover text container
@rstorey
Copy link
Member Author

rstorey commented Jun 3, 2019

This is fixed as of #1045

@rstorey rstorey closed this as completed Jun 3, 2019
klee72 added a commit that referenced this issue Jun 4, 2019
@klee72
#998
90dc240
@klee72 klee72 mentioned this issue Jun 5, 2019
Merged
acdha added a commit that referenced this issue Jun 5, 2019
@acdha
Merge pull request #1050 from LibraryOfCongress/activity-ui-prototype
d252850 
#998 Reduced padding for hover text box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klee72 klee72

@jbresner jbresner

Labels
Activity UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klee72 @jbresner @rstorey