PICKME Refactor Email system to builder pattern #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 25, 2024 11:29
Those should only be provided by the user.
The name is misleading, as it's not the default.language setting
DisplayLocalized in SmartyPage was never called DisplayLocalized in Page was only a copy, which is still called, but the languageCode parameter is not used.
..but only when custom template is available for default lang. refs LibreBooking#416
It conflicts with the now protected email property
Merged
hakito
changed the title
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on a feature it was quite difficult to implement it because of the current architecture of the email system. This PR holds the current state of my approach, but as it was too risky to break something else I stopped working on it. Maybe it's something for Version 3.0?
The
EmailMessageis the base class for all message types and implements an interface. Some of the derived classes have aGetTemplateNamemethod, some don't.I thought the reason for the architecture is because of a manipulation of the
EmailMessageobject after it's creation. But it seems that is not the case. All code paths I found create the message and send it to phpmailer without additional modification.I tried to replace it with a more straighforward builder pattern.
So far I replaced the first view classes with the builder pattern approach. When I came accross
GuestAddedEmailwich derives fromReservationEmailMessagethings got more complicated. I think this could still be resolved when using a mixture of the builder pattern and the derived class pattern here.Todos:
EmailMessage