Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check definition of vals with option split #62

Closed
wants to merge 2 commits into from
Closed

check definition of vals with option split #62

wants to merge 2 commits into from

Conversation

cKlee
Copy link
Contributor

@cKlee cKlee commented May 12, 2017

With $append & split undef values where produced for missing fields.

@cKlee cKlee mentioned this pull request May 12, 2017
Closed
@cKlee
Copy link
Contributor Author

cKlee commented May 12, 2017 •
edited
Loading

Uups! That didn't go so well... Travis is complaining.

@coveralls
Copy link

coveralls commented May 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.761% when pulling 1e9bc5f on cKlee:undef_vals into 4cd86ec on LibreCat:dev.

@cKlee
Copy link
Contributor Author

cKlee commented May 12, 2017 •
edited
Loading

I included #61.

@cKlee cKlee mentioned this pull request May 12, 2017
Closed
@cKlee
Copy link
Contributor Author

cKlee commented May 12, 2017

No sorry! I want travis to check the whole PR not every commit. I close this and make a new PR

@cKlee cKlee closed this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cKlee @coveralls