scripts/create_addon: use PKG_REV as part of the binary addon version #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrusak
force-pushed
the
pkg-rev-binary
branch
from
124fa43
to
d9f3526
Compare
|
fixed up thanks to a suggestion from @MilhouseVH |
|
any objections? @chewitt this will require a rebuild of all the binary add-ons |
|
we need to get this going |
chewitt
approved these changes
Jan 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have always been the case. I have been using this with retroplayer add-ons as often the emulator package would get updated but the binary add-on would stay the same, so the addon version would stay the same but the PKG_REV can allow the new add-on to exist.
This isn't the case for all binary add-ons but many use third party libraries that can be bumped independently from the binary add-on.
all PKG_REV should be reset to
1or100for binary add-ons. I can include that in this PR if all agree.