-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libdvbcsa: AArch64 support #1058
Conversation
e12ffb8
to
5dba4ad
Compare
Update, version change. Fixes glenvt18/libdvbcsa#1. Can anyone build and test it on RPi2/3 with the latest LibreELEC toolchain? Testing instructions: #1053 (comment) |
This builds fine on RPi, RPi2 and Generic. However performance is slightly worse on an RPi3 - down from ~135MB/s to ~131MB/s: |
@MilhouseVH I see
in your paste, but the right hash is glenvt18/libdvbcsa@7360578 (like in this commit). Is it a typo? |
If so, it's OK. Small performance drop (about 3%) is expected on ARM. I sacrificed some performance in favor of safety and maintenance, but I have some ideas how to get it back:) I didn't notice any performance drop on x86 and AArch64 though. Also tests on 32 bit Amlogic showed that the current LibreELEC compiler (6.2) produces code that is about 10% slower on ARM than the one generated by Linaro 5.4. I've also tried Linaro 6.2.1. It's only a little bit better and it doesn't generate ldm instructions which lead to bus errors. But, in practice, 132 Mbit/s you got is not bad at all. |
I've tested this on my Odroid C2 with aarch64 and arm. Works for me. No more bus errors. |
@glenvt18 are you happy with this? do you want to update the git hash? |
5dba4ad
to
7c35462
Compare
@lrusak Here you go. Just to point to my master branch. Though the changes are purely cosmetic. |
This follows #1053.