Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdvbcsa: AArch64 support #1058

Merged
merged 1 commit into from
Dec 27, 2016
Merged

Conversation

glenvt18
Copy link
Contributor

This follows #1053.

@glenvt18
Copy link
Contributor Author

Update, version change. Fixes glenvt18/libdvbcsa#1. Can anyone build and test it on RPi2/3 with the latest LibreELEC toolchain? Testing instructions: #1053 (comment)

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Dec 16, 2016

This builds fine on RPi, RPi2 and Generic.

However performance is slightly worse on an RPi3 - down from ~135MB/s to ~131MB/s:
new: http://pastebin.com/raw/qREwHNCB
old: http://pastebin.com/raw/gEMa3skW

@glenvt18
Copy link
Contributor Author

glenvt18 commented Dec 16, 2016

@MilhouseVH I see

libdvbcsa 1613dd4 (post-#1058) on RPi3 (kodi not running):

in your paste, but the right hash is glenvt18/libdvbcsa@7360578 (like in this commit). Is it a typo?

@MilhouseVH
Copy link
Contributor

Sorry fat fingers - I was simultaneously looking at this PR and also #1053, and I copied the rev from #1053. The "post-#1058" rev should have been 7360578 (and in fact is, when I look at the package.mk in my repo).

@glenvt18
Copy link
Contributor Author

If so, it's OK. Small performance drop (about 3%) is expected on ARM. I sacrificed some performance in favor of safety and maintenance, but I have some ideas how to get it back:) I didn't notice any performance drop on x86 and AArch64 though.

Also tests on 32 bit Amlogic showed that the current LibreELEC compiler (6.2) produces code that is about 10% slower on ARM than the one generated by Linaro 5.4. I've also tried Linaro 6.2.1. It's only a little bit better and it doesn't generate ldm instructions which lead to bus errors. But, in practice, 132 Mbit/s you got is not bad at all.

@Ray-future
Copy link
Contributor

Ray-future commented Dec 17, 2016

I've tested this on my Odroid C2 with aarch64 and arm. Works for me. No more bus errors.

@lrusak
Copy link
Member

lrusak commented Dec 27, 2016

@glenvt18 are you happy with this? do you want to update the git hash?

@glenvt18
Copy link
Contributor Author

@lrusak Here you go. Just to point to my master branch. Though the changes are purely cosmetic.

@lrusak lrusak merged commit a5d29bc into LibreELEC:master Dec 27, 2016
@glenvt18 glenvt18 deleted the libdvbcsa-aarch64 branch December 27, 2016 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants