-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: rename docker to moby #1670
Conversation
de4275f
to
99dc3b5
Compare
added changelog entry and drop ADDON variables from moby package.mk docker PKG_SECTION should now virtual, because it is only a wrapper for moby and tools. |
I'm ok with this as it will continue to be named |
Why not just change PKG_ADDON_NAME, PKG_LONGDESC and PKG_SHORTDESC, which are purely cosmetic, to Moby? Is there such a thing as a copyrighted/trademarked file/service name? |
When i correct understand it, docker will divided into several parts/modules. edit: update description in moby package. rebase against master |
This absolutely will need to happen but in my opinion this is not the time for us to be trailblazing. Accept and park until the world understands what the Moby distinction is and the dust has settled on the final re-brand (or we run the risk of having to do this more than once). |
for now others didnt make move to change name, here i mean companies like Synology, QNAP, LimeTech (unraid) etc. |
Sorry, I might be thick, but I still do not get why the docker package has to be split into a moby and a docker packages, especially since a docker package remains. Why not simply change the name displayed in the Kodi user interface, via PKG_ADDON_NAME, PKG_LONGDESC and PKG_SHORTDESC. |
@awiouy we need to separate the packages so we can continue to use the same add-on name which is service.system.docker. If that were to change then people would lose their data. It's how our build system works by taking the PKG_NAME and the PKG_SECTION |
@lrusak I am aware of that, adding addons to LibreELEC is my trade. I still do not understand the rationale behind the split/rename. The addon can be renamed in the Kodi user interface without changing PKG_NAME or PKG_SECTION. Additional components can be shipped within the package or added from separate packages. Could anyone here explain the purpose of the moby package, apart from creating an apparently useless matryoshka? |
believe not needed after #1796 |
@InuSasha I'd still like to do it this way. |
I'd prefer to leave this open so the topic isn't forgotten about, regardless of what form we commit something in at a later stage. @InuSasha we can very slow at this stuff sometimes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like those changes too. It clearly divides the package like it is upstream. Makes a lot of sense to me.
rebase to current master, to solve merge conflicts |
No description provided.