Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux: add --without-ncursesw to config #2236

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

chewitt
Copy link
Member

@chewitt chewitt commented Nov 20, 2017

On our main build server I see failures with util-linux 2.31 related to it finding some ncurses libs and maybe not respecting the --without-ncurses switch. Looking at the commits between 2.30 which works fine and 2.31 which does not; reverting https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=87c26ce5b689abe1b52181f98ef3c9eb1b1a5165 "fixes" the issue, e.g. with the patch:

checking for armv7ve-libreelec-linux-gnueabi-ncursesw6-config... no
checking for ncursesw6-config... no
checking for armv7ve-libreelec-linux-gnueabi-ncursesw5-config... no
checking for ncursesw5-config... ncursesw5-config
checking ncursesw/ncurses.h usability... no
checking ncursesw/ncurses.h presence... no
checking for ncursesw/ncurses.h... no
checking ncursesw/term.h usability... no
checking ncursesw/term.h presence... no
checking for ncursesw/term.h... no

and without it (ncurses things found):

checking for armv7ve-libreelec-linux-gnueabi-ncursesw6-config... no
checking for ncursesw6-config... no
checking for armv7ve-libreelec-linux-gnueabi-ncursesw5-config... no
checking for ncursesw5-config... ncursesw5-config
checking ncursesw/ncurses.h usability... no
checking ncursesw/ncurses.h presence... no
checking for ncursesw/ncurses.h... no
checking ncursesw/term.h usability... no
checking ncursesw/term.h presence... no
checking for ncursesw/term.h... no
checking ncurses.h usability... yes
checking ncurses.h presence... yes
checking for ncurses.h... yes
checking term.h usability... yes
checking term.h presence... yes
checking for term.h... yes
checking for use_default_colors in -lncursesw... no
checking for resizeterm in -lncursesw... no

I'm submitting the PR in the hope that someone who understands compile stuff can spot the issue and come up with a better fix - consider it a placeholder

@vpeter4
Copy link
Contributor

vpeter4 commented Nov 20, 2017

You should compare config.log in both cases which would tell the difference.

@CvH
Copy link
Member

CvH commented Nov 20, 2017

after installing apt install libncursesw5-dev I get the same problem

fix: CvH@d71c581

@chewitt chewitt changed the title util-linux: revert ncurses detect commit in 2.31 util-linux: add --disable-ncursesw to config Nov 20, 2017
@chewitt chewitt changed the title util-linux: add --disable-ncursesw to config util-linux: add --without-ncursesw to config Nov 20, 2017
@chewitt
Copy link
Member Author

chewitt commented Nov 20, 2017

PR updated to @CvH finding .. thanks!

@CvH CvH merged commit 66095c1 into LibreELEC:master Nov 20, 2017
@chewitt chewitt deleted the build-errors branch December 7, 2017 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants