Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKG_STAMP to trigger a package rebuild #2431

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Conversation

Kwiboo
Copy link
Member

@Kwiboo Kwiboo commented Jan 23, 2018

This PR adds support for using PKG_STAMP to trigger a package rebuild (extracted from #2328)

u-boot package is changed to use PKG_STAMP instead of a special UBOOT_SYSTEM hack in scripts/build to trigger package rebuild when UBOOT_SYSTEM changes
linux package will be rebuild when changes is made to make targets parameters in options-file

Another example of usage is for the mali-rockchip package, see Kwiboo@505b753 (triggers a package rebuild if options is changed to use another x11/wayland/gbm driver)

@spycat88
Copy link
Contributor

Could this be expanded so if there is changes to initramfs to rebuild busybox/initramfs/linux?

@MilhouseVH
Copy link
Contributor

Could this be expanded so if there is changes to initramfs to rebuild busybox/initramfs/linux?

No because you'll likely be caught in a circular dependency - initramfs is built from within linux so it's not possible for initramfs to rebuild linux.

There also comes a point where you can only go so far with automated cleaning before you might as well clean build every time.

@chewitt
Copy link
Member

chewitt commented Mar 2, 2018

@Kwiboo can you rebase against changes in scripts/build please

@vpeter4
Copy link
Contributor

vpeter4 commented Aug 1, 2018

This is something useful - can be merged?

@Kwiboo
Copy link
Member Author

Kwiboo commented Aug 22, 2018

Rebased on latest LE master

Copy link
Contributor

@kszaq kszaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kwiboo Is this still a WIP? It works for me just fine. 👍

@kszaq kszaq requested a review from MilhouseVH April 12, 2019 10:04
@chewitt chewitt merged commit 20eaca6 into LibreELEC:master Apr 12, 2019
@Kwiboo Kwiboo deleted the pkg-stamp branch April 13, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants