config: enable CONFIG_BPF_SYSCALL and CONFIG_CGROUP_BPF #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGROUP_BPF is needed by systemd firewalling. Enabling the
option removes the systemd warning ("Proceeding WITHOUT
firewalling in effect!") during boot.
Signed-off-by: Matthias Reichl <hias@horus.com>
|
Fyi: systemd/systemd#7188, fixed in 236 (and 237 released yesterday). Unless we need the systemd firewall would it be better to accept the one-off log noise? |
|
That systemd issue is where I got the CGROUP_BPF hint from (we tried BPF_SYSCALL=y without success before - as another user in the issue thread). I'm not sure if we want or need the systemd firewall, but as systemd wants the firewall - IPAddressDeny is in 6 service files - IMHO it's better to make it happy and just enable the option. BTW: We'll still get the warning on Amlogic devices as their kernel is too old and doesn't support BPF_SYSCALL |
|
RPi and RPi2 Milhouse builds work fine with this, feel free to merge |
MilhouseVH
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGROUP_BPF is needed by systemd firewalling. Enabling the
option removes the systemd warning ("Proceeding WITHOUT
firewalling in effect!") during boot.
Note: only tested on RPi2 so far