Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapcast: update to 0.15.0 #2716

Merged
merged 8 commits into from
Jul 11, 2018
Merged

snapcast: update to 0.15.0 #2716

merged 8 commits into from
Jul 11, 2018

Conversation

awiouy
Copy link
Collaborator

@awiouy awiouy commented May 21, 2018

No description provided.

@awiouy awiouy mentioned this pull request May 21, 2018
Closed
@awiouy
Copy link
Collaborator Author

awiouy commented Jun 12, 2018

Still waiting for shairport-sync 3.2 to be released

@awiouy awiouy changed the title snapcast: update to 0.14.0 snapcast: update to 0.15.0 Jul 10, 2018
@awiouy
Copy link
Collaborator Author

awiouy commented Jul 10, 2018

Updated and rebased. Please review.

@chewitt chewitt merged commit 5c8acd4 into LibreELEC:master Jul 11, 2018
chewitt added a commit that referenced this pull request Jul 11, 2018
@chewitt
Merge pull request #2717 from awiouy/82-snapcast-14
4b72147 
snapcast: backport of #2716
@diabl0w
Copy link

diabl0w commented Mar 31, 2020

the alsa-plugins are useless, alsa-lib is hardcoded with a plugindir of /usr/lib/alsa and this addon installs alsa-plugins to its own kodi addon directory... setting LD_LIBRARY_PATH does not affect alsa and so it isnt fixing anything

@diabl0w
Copy link

diabl0w commented Mar 31, 2020 •
edited
Loading

maybe this can be incorporated:
NixOS/nixpkgs@862fcb0

It allows setting a ALSA_PLUGINS_DIR environment variable, and it could take multiple arguments, so that kodi addons can add their own alsa plugins instead of requesting a new plugin be added to LibreELEC

or this which allows setting libs entry in asound.conf
NixOS/nixpkgs@ab8ef63

edit: sorry for all the edits, but this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/alsa-lib/alsa-plugin-conf-multilib.patch
is what we should implement, as its currently being used in NixOS since 2014 so that means it should be clean and stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewitt chewitt chewitt approved these changes

Assignees
No one assigned
Labels
ADDONS LE 9.0 UPDATE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awiouy @diabl0w @chewitt