ConnMan: use UseGatewaysAsTimeservers option #2818
Conversation
|
Thanks @chrisnovakovic - I'll include this in test builds for the next few days just to be on the safe side, even though it doesn't look like it's going to cause any problems. |
|
The |
|
@MilhouseVH You're quite right, sorry - I didn't think there had been any significant changes to |
Upstream commits 20f20417 ("main: Add UseGatewaysAsTimeservers option")
and 3ce40776 ("timeserver: Use gateways as timeservers if
UseGatewaysAsTimeservers=true") change ConnMan's behaviour regarding the
use of default gateways as timeservers: this is now a configurable
option at run-time, with the default setting being to disable this
behaviour. These commits obsolete one of LibreELEC's custom patches,
connman-04-do-not-add-default-gw-as-timeserver.patch.
Prepare for the next stable release of ConnMan by cherry-picking these
commits from upstream (with minor modifications to commit 20f20417 so it
applies cleanly to 1.36) and using the new UseGatewaysAsTimeservers
option in /etc/connman/main.conf to forcefully disable the feature,
which matches the behaviour of the LibreELEC patch. The cherry-picked
upstream commits can be dropped when a new stable version of ConnMan is
released and LibreELEC upgrades to it.
chrisnovakovic
force-pushed
the
master-connman-gateway-timeserver
branch
2 times, most recently
from
bdf22be
to
3d9033f
Compare
|
This one applies cleanly and compiles correctly. |
|
Thanks, looks good now (builds fine on RPi/RPi2/Generic). I'll include for a few days in test builds, and if no problems we should be able to merge middle of next week. |
|
lol sorry for the spam, but I could not resist :D |
|
Mistakes were made, let's leave it at that... 😉 |
|
No reported issues so far, I reckon this can go in. Thanks @chrisnovakovic ! |
|
@chrisnovakovic I spotted this when working on some connman issues with one of their developers: https://lists.01.org/pipermail/connman/2019-March/023277.html should be resolved in the next connman bump |
|
@chewitt Good spot, thanks! No idea how that happened... |
I recently implemented runtime-configurable support for ConnMan's "use default gateway as timeserver" feature and had it accepted upstream (the salient commits are
20f20417and3ce40776). The default is for this behaviour to be disabled, as it's only useful in a tiny number of (broken) network setups and is almost always the wrong thing to do everywhere else. This new feature obsoletes LibreELEC's custom patchconnman-04-do-not-add-default-gw-as-timeserver.patch, which hard-codes the same behaviour at compile-time.This PR cherry-picks the upstream commits implementing this feature, disables it by setting
UseGatewaysAsTimeservers=falsein/etc/connman/main.conf(not strictly necessary, but useful in case upstream decides to change the default behaviour someday), and dropsconnman-04-do-not-add-default-gw-as-timeserver.patch(as it's no longer necessary). When ConnMan 1.37 is released and we upgrade to it,connman-00-upstream-main-Add-UseGatewaysAsTimeservers-option.patchandconnman-00-upstream-timeserver-UseGatewaysAsTimeservers.patchcan also be dropped.