kodi: building with ninja makes xbmc/1600 more likely - don't use ninja #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiassofT
approved these changes
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kodi occasionally fails to build due to xbmc/xbmc#16000.
It appears that
ninjais more likely to cause this failure thancmake-make- I've tested 1,000cmake-makeKodi builds with 0 (zero) failures, and 250ninjabuilds with 4 failures (all due to issue xbmc/16000).Team Kodi has seen this same failure when using
cmakeand their own Jenkins, so this PR may not eliminate the issue entirely (which could be akodiand/orcmakeissue, made worse byninja) but should hopefully make it less of an issue for LibreELEC until it is fixed (if it is ever fixed).