Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: bump repository.libreelec.tv to 8.1 for consistency #995

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

chewitt
Copy link
Member

@chewitt chewitt commented Nov 28, 2016

I'm not entirely sure whether this is supposed to be 8.0.0 repo to match 8.0.0 release or 8.1.0 repo to match 8.1 repo version. Merge or close as appropriate.

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Nov 28, 2016

Not sure it matters, to be honest - the version is something that would be relevant if this file were something that could be downloaded and installed, but that isn't the case with this file, as it's "baked" into the build so the version is irrelevant.

Either version number works as well as the other, with the latest builds pulling updates from the 8.1 repo (ie. http://addons.libreelec.tv/8.1/RPi2/arm/addons.xml.gz.md5) thanks to ADDON_VERSION so the version number in this file is purely cosmetic, and I'd leave it at 8.0.0 (ie. close this PR) otherwise we're bumping this for no benefit.

In fact, leaving it at 1.0.0 forever would also work, I think.

@lrusak
Copy link
Member

lrusak commented Dec 6, 2016

I'm fine with this either way. It's purely cosmetic

@lrusak lrusak added the Cleanup label Dec 6, 2016
@chewitt
Copy link
Member Author

chewitt commented Dec 7, 2016

leave open a bit longer .. I'll add the fanart image to settings and add the bump here

@chewitt chewitt closed this Dec 11, 2016
@chewitt chewitt deleted the repo_version branch December 11, 2016 05:37
@chewitt chewitt restored the repo_version branch December 11, 2016 05:37
@chewitt chewitt reopened this Dec 11, 2016
@MilhouseVH MilhouseVH merged commit 968855e into LibreELEC:master Dec 21, 2016
@chewitt chewitt deleted the repo_version branch February 1, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants