connman.py: More secure default password for tethering #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll include this in test builds. |
|
Thanks. If someone already used wifi tethering and set a password or used that "libreelec" default it will not override it obviously. |
|
Seems to be working fine. If anyone wishes to test (and has previously enabled tethering), they should
When tethering is re-enabled, it should now have a random passphrase, eg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling Wifi tethering always defaults to the password: libreelec. Since the SSID defaults to LibreELEC-AP it is a pretty simple password to guess.
Now a 10 character long random (digits and letters only) string is generated by default. Not sure about the 10 characters is too long or too short.