Translate German Comments #440
Conversation
Signed-off-by: andreasma <maand@gmx.de>
Signed-off-by: andreasma <maand@gmx.de>
Signed-off-by: andreasma <maand@gmx.de>
| @@ -23,15 +23,15 @@ | |||
| package de.muenchen.allg.itd51.wollmux.former; | |||
|
|
|||
| /** | |||
| * Interface für Nachrichten auf dem globalen Broadcast-Kanal. Siehe auch | |||
| * Interface for messages on the global broadcast channel. See also | |||
There was a problem hiding this comment.
Hmm - a literal translation is not ideal here (as this is an interface description).
Its an implementation of https://en.wikipedia.org/wiki/Publish-subscribe_pattern - so perhaps add a link in the line below, and tweak the mission statement to 'Interface for sending a message on the global pubsub channel' (or somesuch)?
| * {@link de.muenchen.allg.itd51.wollmux.former.BroadcastListener}. | ||
| * | ||
| * @author Matthias Benkmann (D-III-ITD 5.1) | ||
| */ | ||
| public interface Broadcast | ||
| { | ||
| /** | ||
| * Sendet diese Broadcast-Nachricht an listener. | ||
| * Send this broadcast message to listener. |
There was a problem hiding this comment.
also mention 'global' here?
| @@ -23,8 +23,8 @@ | |||
| package de.muenchen.allg.itd51.wollmux.former; | |||
|
|
|||
| /** | |||
| * Nachricht, dass in einer View ein Object ausgewählt wurde. Diese Nachricht wird | |||
| * von anderen Views ausgewertet, um ihre Selektionen ebenfalls anzupassen. | |||
| * Message that an object was selected in a view. This message will be | |||
There was a problem hiding this comment.
bit bumpy - how about: ..message for notifying object selection in a View.. (please upper-case View, it's a noun & used as classname elsewhere)
| */ | ||
| private int state; | ||
|
|
||
| /** | ||
| * true => Selektion erst ganz löschen vor an/abwählen des Objektes. | ||
| * true => Selektion delete complete first bevor selecting/deselecting the object. |
There was a problem hiding this comment.
..delete fully, before.. ?
| * @param clearSelection | ||
| * true => Selektion erst ganz löschen vor an/abwählen von myObject. | ||
| * true => Selektion delete complete first bevor selecting/deselecting of myObject. |
| @@ -74,15 +74,15 @@ public int getState() | |||
| } | |||
|
|
|||
| /** | |||
| * true => Selektion erst ganz löschen vor an/abwählen des Objekts. | |||
| * true => Selektion delete complete first bevor selecting/deselecting the object. | |||
core/src/main/java/de/muenchen/allg/itd51/wollmux/former/ComboboxMergeDescriptor.java
Show resolved
Hide resolved
| * wird, der den ComboBox-Wert beschreibt, den auszuwählen dem Aktivieren der alten | ||
| * Checkbox entspricht. | ||
| * A {@link Map}, which keys are the {@link IdModel}s of the checkboxes, | ||
| * which have been merged, in which every of these IDs were mapped on a string, |
| * Checkbox entspricht. | ||
| * A {@link Map}, which keys are the {@link IdModel}s of the checkboxes, | ||
| * which have been merged, in which every of these IDs were mapped on a string, | ||
| * which describes the combobox value. The choose one of them matches the activation of the old |
There was a problem hiding this comment.
That's completely mangled. "Selecting one of those strings corresponds to activating the respective, previous checkbox"
Signed-off-by: andreasma <maand@gmx.de>
|
I checked your comments and amended the translations according to your hints. |
| @@ -74,7 +74,7 @@ public int getState() | |||
| } | |||
|
|
|||
| /** | |||
| * true => Selektion delete complete first bevor selecting/deselecting the object. | |||
| * true => Selektion delete fully bevor selecting/deselecting the object. | |||
There was a problem hiding this comment.
Hmm, I guess Selektion needs translation too, as well as bevor (and swapping verb and object is more idiomatic English, i.e. 'Delete selection fully, before ...)
Signed-off-by: andreasma <maand@gmx.de>
|
Thanks for your hints. I fixed the last bits. |
No description provided.