Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library manual #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Library manual #42

wants to merge 4 commits into from

Conversation

ouabache
Copy link

No description provided.

@ubruhin
Copy link
Member

ubruhin commented Dec 29, 2019

This adds a lot of useless files inside the Library_Manual directory (.editorconfig, .gitattributes, CONTRIBUTING.md, ...), could you please remove them? And could you maybe rebase the branch to master and get rid of the merge commit? IMHO it's very hard to understand the current commit history ;)

In addition, the new content will not appear in the hosted documentation since it is not included anywhere...

@ouabache
Copy link
Author

ouabache commented Dec 30, 2019 via email

@ubruhin
Copy link
Member

ubruhin commented Jan 6, 2020

Done

Where? 😁 There was no push on this branch ;)

@ouabache
Copy link
Author

ouabache commented Jan 6, 2020 via email

@rnestler
Copy link
Member

rnestler commented Jun 3, 2020

I show it in my LibrePCB repo under branch library_manual

The branch name for this PR is called Library_Manual, maybe that's the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants