AutoCloseable interface for classes that already implement it #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e close method removed it from Document, because it inherits/implements it now transitively via DocListener
|
Kudos, SonarCloud Quality Gate passed!
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
|
@asturio, could this please be merged? |
asolntsev
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
I added the AutoCloseable interface on those classes which already implement it. Most of them seem to use it to close files or streams in their implementation, so it is recommended to give them this interface.
Related Issue: Problem/enhancement mentioned in #812
Unit-Tests for the new Feature/Bugfix
No new tests needed, because it does not introduce a new feature or fix a bug or change.
Compatibilities Issues
No issues to be expected, but linters will suggest the dev to use try-with-resources.
Testing details
--