Add tests and github actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 🎉
|
| afterEach(() => { | ||
| nock.cleanAll() | ||
| nock.enableNetConnect() | ||
| it('Returns an error if something fails to create a pull-request request', async (done) => { |
There was a problem hiding this comment.
Why this PR would fail? I found it difficult to figure it out. Also, I noticed that running the tests takes several seconds, and I guess this setTimeout is related to that delay, why do we have it here?
| let mockCert: string | ||
|
|
||
| beforeAll((done: Function) => { | ||
| fs.readFile(path.join(__dirname, 'fixtures/mock-cert.pem'), (err: Error, cert: string) => { | ||
| fs.readFile(path.join(__dirname, 'fixtures/mock-cert.pem'), (err: NodeJS.ErrnoException | null, cert: Buffer) => { | ||
| if (err) return done(err) |
There was a problem hiding this comment.
Which case are we trying to catch here? What does done do with the err parameter?
|
Just because I'm curious, Is it possible to use github API to accomplish this task without using with github Apps? If so, is there any real advantage at using github app in our use case? |
germanferrero
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.