Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Buttons Stuck On Bottom Right Corner #3

Closed
poudink opened this issue Apr 7, 2022 · 6 comments
Closed

Download Buttons Stuck On Bottom Right Corner #3

poudink opened this issue Apr 7, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@poudink
Copy link

poudink commented Apr 7, 2022

The download buttons don't seem to appear correctly. They work, but they're totally stuck at the bottom right corner of the screen, constantly hiding that part and pretty inconvenient. I took the screenshot below with uBlock Origin and Dark Reader enabled, but this happens regardless of whether other extensions are enabled, so it can't be interference.

I've observed this issue with:
Violentmonkey, Firefox, Linux
Tampermonkey, Firefox, Linux
Violentmonkey, Opera, Windows 7
Violentmonkey, Opera GX, Windows 10

I also tried Firemonkey and Greasemonkey just in case, but the userscript didn't work at all there.

I know for a fact this used to work fine a long time ago (it's probably been a couple of years at this point) and would place the download buttons below the Share/Add to set buttons. It just suddenly broke one day and I didn't think to open an issue until now.
image

@PeterNjeim
Copy link
Member

PeterNjeim commented Apr 7, 2022

The reason they're anchored now is to avoid Musescore's detection. This has been the case for over a year now. It shouldn't block anything, sometimes there are even two scroll bars (if the browser width is small enough) to make sure you can reach everything you need.

@PeterNjeim
Copy link
Member

If you mean you want a dark mode version of it to not blind your eyes (since dark reader can't do it as it's anchored and rendered after the initial page render), then I could probably do it at a later time

@PeterNjeim PeterNjeim added enhancement New feature or request wontfix This will not be worked on labels Jun 23, 2022
@PeterNjeim PeterNjeim closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2022
@Xmader
Copy link
Member

Xmader commented Feb 28, 2023

it's anchored and rendered after the initial page render

There should be an easy fix. I've worked on it before, but I don't if anything changes.

@Xmader Xmader reopened this Feb 28, 2023
@Xmader Xmader removed the wontfix This will not be worked on label Feb 28, 2023
@DereC4
Copy link

DereC4 commented Mar 1, 2023

In my opinion, an acceptable cosmetic loss for an awesome downloader!

@DereC4
Copy link

DereC4 commented Mar 1, 2023

I'm wondering how this would be fixed though; looks like right now it's more of an overlay in the user screen than embedded into site html

@PeterNjeim PeterNjeim changed the title Download Buttons Stuck On Bottom Left Corner Download Buttons Stuck On Bottom Right Corner Aug 7, 2023
@PeterNjeim
Copy link
Member

Fixed in df36815. Update to v0.35.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants