Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autograd: add executor to cache key for make_aug_forward_and_backward #238

Merged
merged 3 commits into from
Apr 24, 2024
Merged

autograd: add executor to cache key for make_aug_forward_and_backward #238

merged 3 commits into from
Apr 24, 2024

Conversation

kshitij12345
Copy link
Collaborator

Fixes: #230

IvanYashchuk
IvanYashchuk approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@IvanYashchuk IvanYashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should merge it.

thunder/tests/test_grad.py Show resolved Hide resolved
thunder/core/vjp_utils.py Outdated Show resolved Hide resolved
@IvanYashchuk IvanYashchuk added autograd bug Something isn't working labels Apr 22, 2024
@kshitij12345 @IvanYashchuk
Update thunder/core/vjp_utils.py
abd347f 
Co-authored-by: Ivan Yashchuk <IvanYashchuk@users.noreply.github.com>
@kshitij12345 kshitij12345 marked this pull request as ready for review April 22, 2024 09:15
@IvanYashchuk IvanYashchuk enabled auto-merge (squash) April 22, 2024 09:20
crcrpar
crcrpar reviewed Apr 22, 2024
View reviewed changes
thunder/core/transforms.py Outdated Show resolved Hide resolved
@kshitij12345 @crcrpar
Update thunder/core/transforms.py
fa50c34 
Co-authored-by: Masaki Kozuki <mkozuki@nvidia.com>
@kshitij12345
Copy link
Collaborator Author

@t-vi can you please have a look and stamp this. Thanks!

@IvanYashchuk IvanYashchuk merged commit 1fd101c into Lightning-AI:main Apr 24, 2024
39 checks passed
@github-actions github-actions bot deleted the add-exec-vjp-symbol-cache branch July 23, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@crcrpar crcrpar crcrpar approved these changes

@carmocca carmocca carmocca approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
autograd bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cuDNN executor leaks to some other benchmarks if run first in the list
4 participants
@kshitij12345 @carmocca @crcrpar @IvanYashchuk