Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add record_history flag to thunder.jit. Off by default. Fixes memory issues. #239

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Add record_history flag to thunder.jit. Off by default. Fixes memory issues. #239

merged 5 commits into from
Apr 21, 2024

Conversation

apaz-cli
Copy link
Collaborator

Bikeshedding on the name is appreciated.

Also, recently we started calling it the "interpreter log." Going to end up renaming it either way.

@t-vi
Copy link
Collaborator

t-vi commented Apr 20, 2024

I like interpreter_log (and this is user facing), so using that is likely a good idea.

@t-vi t-vi enabled auto-merge (squash) April 21, 2024 18:28
t-vi
t-vi reviewed Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have it. Thank you @apaz-cli

@t-vi t-vi merged commit 23bb666 into main Apr 21, 2024
39 checks passed
@t-vi t-vi deleted the ap-default_disable_history branch April 21, 2024 18:29
@apaz-cli apaz-cli mentioned this pull request Apr 21, 2024
Closed
@IvanYashchuk IvanYashchuk mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaz-cli @t-vi