Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route model access through the thunder module #279

Merged
merged 10 commits into from
May 6, 2024
Merged

route model access through the thunder module #279

merged 10 commits into from
May 6, 2024

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Apr 25, 2024

...then we can override parameters etc. on the thunder module.

@t-vi
Copy link
Collaborator Author

t-vi commented Apr 25, 2024

I'll need to fix that some things (such as __globals__) still need to go directly onto the original modules.

@t-vi t-vi marked this pull request as ready for review April 26, 2024 09:56
@t-vi t-vi enabled auto-merge (squash) April 26, 2024 09:57
crcrpar
crcrpar reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@crcrpar crcrpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a feedback, just a few questions

thunder/__init__.py Outdated Show resolved Hide resolved
thunder/__init__.py Outdated Show resolved Hide resolved
carmocca
carmocca reviewed Apr 26, 2024
View reviewed changes
thunder/__init__.py Outdated Show resolved Hide resolved
thunder/__init__.py Outdated Show resolved Hide resolved
thunder/core/prims.py Outdated Show resolved Hide resolved
thunder/__init__.py Show resolved Hide resolved
@t-vi t-vi mentioned this pull request May 3, 2024
Merged
carmocca
carmocca approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-vi t-vi merged commit b1f4470 into main May 6, 2024
37 checks passed
@t-vi t-vi deleted the tom/tomasproxy branch May 6, 2024 09:10
@t-vi
Copy link
Collaborator Author

t-vi commented May 6, 2024

Thank you @carmocca @crcrpar

@IvanYashchuk IvanYashchuk mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crcrpar crcrpar crcrpar left review comments

@carmocca carmocca carmocca approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-vi @carmocca @crcrpar