Remove batched generation support #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Apr 19, 2023
awaelchli
reviewed
Apr 19, 2023
| # if the sequence context is growing too long we must crop it at max_seq_length | ||
| idx_cond = idx_cond if T <= max_seq_length else idx_cond[:, -max_seq_length:] | ||
| idx_cond = idx_cond if T <= max_seq_length else idx_cond[-max_seq_length:] | ||
|
|
||
| # forward | ||
| logits = model(idx_cond) |
There was a problem hiding this comment.
The model still expects a batch, so the input tensor needs to be expanded here.
There was a problem hiding this comment.
Yes. Merged too hastily, sorry about that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #153
Closes #49