Support DDP #81
Merged
Support DDP #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
commented
Apr 2, 2023
awaelchli
commented
Apr 2, 2023
|
I think the original request was referring to multi-gpu, be it ddp, fsdp or deepspeed. I’m in favor of merging this after the rope fix, but I’d probably avoid showing ddp since it can’t possibly work, and rather make sure fsdp works instead. WDYT? |
lantiga
approved these changes
Apr 2, 2023
timothylimyl
referenced
this pull request
in timothylimyl/lit-llama-qa
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
Note, while we can enable DDP here, training/finetuning the model with DDP won't work on most systems as the model/optimizer/gradients simply can't fit in memory. This PR is just for correctness and because of the question that popped up in #80.