Update test_readme.py #1505
Merged
Update test_readme.py #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember adding the Windows dependency skip up at the model download because the Windows machine was already very slow and often timing out. If it runs ok now, we can enable it. |
|
Odd. But we are talking about Windows, so I guess it's expected 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Currently
tests/test_readme.py::test_download_modelskips Windows and MacOS platforms, and since the test is a dependency for other tests they are skipped too.But model download should work on all platforms without problems.
This PR fixes it.
Plus adds a skip (for non-Linux OS) for pretraining tests since pretraining requires
torch.compilewhich is supported only on Linux.