Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure reset method works in notebooks #1093

Merged
merged 2 commits into from
Mar 19, 2020
Merged

ensure reset method works in notebooks #1093

merged 2 commits into from
Mar 19, 2020

Conversation

jeremyjordan
Copy link
Contributor

@jeremyjordan jeremyjordan commented Mar 8, 2020 •
edited by Borda
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1092 most likely also #1112

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@jeremyjordan jeremyjordan requested a review from a team March 8, 2020 16:42
Borda
Borda approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda
Copy link
Member

Borda commented Mar 11, 2020

hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@Borda Borda added the bug Something isn't working label Mar 12, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 12, 2020
@Borda Borda mentioned this pull request Mar 14, 2020
Closed
@Borda Borda linked an issue Mar 14, 2020 that may be closed by this pull request
No progress bar when training on Google Colab #1112
Closed
@Borda
Copy link
Member

Borda commented Mar 16, 2020

@jeremyjordan we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@jeremyjordan
Copy link
Contributor Author

@Borda oops, thanks for the tag - somehow missed your first message.

@Borda Borda added the ready PRs ready to be merged label Mar 18, 2020
@williamFalcon williamFalcon merged commit 36274be into Lightning-AI:master Mar 19, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@jeremyjordan @tullie
ensure reset method works in notebooks (Lightning-AI#1093)
ac588c2
@yikuanli
Copy link

Sorry, not sure I understand what's the solution here, could you please be more specific what do you mean about reset methods ? Thanks a lot

@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

No progress bar when training on Google Colab tqdm fails in notebook for versions tqdm< 4.41.0
4 participants
@jeremyjordan @Borda @yikuanli @williamFalcon