Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing install from src package & CI release #16027

Merged
merged 16 commits into from
Dec 21, 2022
Merged

fixing install from src package & CI release #16027

merged 16 commits into from
Dec 21, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 13, 2022 •
edited by github-actions bot
Loading

What does this PR do?

in #15986 we had to disable install from tar.gz so some issues so will debug it here...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton

@Borda Borda added the bug Something isn't working label Dec 13, 2022
@Borda Borda added the priority: 1 Medium priority task label Dec 13, 2022
@Borda Borda added this to the v1.8.x milestone Dec 13, 2022
@Borda Borda changed the title CI: debug install from src package CI: fixing install from src package Dec 13, 2022
@Borda Borda marked this pull request as ready for review December 13, 2022 11:51
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to setup.py.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.9, 1.10, 11.3.1) success ✅
build-cuda (3.9, 1.11, 11.3.1) success ✅
build-cuda (3.9, 1.12, 11.6.1) success ✅
build-cuda (3.9, 1.13, 11.6.1) success ✅
build-hpu (1.5.0, 1.11.0) success ✅
build-ipu (3.9, 1.10) success ✅
build-NGC success ✅
build-pl (3.9, 1.10, 11.3.1) success ✅
build-pl (3.9, 1.11, 11.3.1) success ✅
build-pl (3.9, 1.12, 11.6.1) success ✅
build-pl (3.9, 1.13, 11.6.1) success ✅
build-xla (3.7, 1.12) success ✅

These checks are required after the changes to setup.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success ✅
app-pytest (macOS-11, app, 3.8, oldest) success ✅
app-pytest (macOS-11, lightning, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, app, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅
app-pytest (windows-2022, app, 3.8, oldest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅

These checks are required after the changes to setup.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (macOS-11, app, 3.9, oldest) success ✅
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, app, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅
app-examples (windows-2022, app, 3.9, oldest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅

These checks are required after the changes to setup.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to setup.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to setup.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, lite, 3.7) success ✅
install-pkg (ubuntu-22.04, lite, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, lite, 3.7) success ✅
install-pkg (macOS-12, lite, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, lite, 3.7) success ✅
install-pkg (windows-2022, lite, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to .github/actions/pkg-install/action.yml, .github/workflows/_build-packages.yml, .github/workflows/ci-pkg-install.yml, setup.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested review from ethanwharris, awaelchli and a team December 13, 2022 11:56
@Borda Borda changed the title CI: fixing install from src package fixing install from src package & CI release Dec 13, 2022
@Borda Borda enabled auto-merge (squash) December 13, 2022 11:58
carmocca
carmocca reviewed Dec 13, 2022
View reviewed changes
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@Borda @carmocca
drop print
1e43d73 
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@mergify mergify bot removed the has conflicts label Dec 13, 2022
akihironitta
akihironitta approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

carmocca
carmocca approved these changes Dec 21, 2022
View reviewed changes
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2022
@Borda Borda merged commit fee671a into master Dec 21, 2022
@Borda Borda deleted the ci/install-src branch December 21, 2022 08:58
carmocca pushed a commit that referenced this pull request Dec 22, 2022
@Borda @carmocca
fixing install from src package & CI release (#16027)
ba43d8a 
* debug install
* hotfix
* local
* refactor
* lit swap
* pruning
carmocca pushed a commit that referenced this pull request Dec 22, 2022
@Borda @carmocca
fixing install from src package & CI release (#16027)
c2a6ca6 
* debug install
* hotfix
* local
* refactor
* lit swap
* pruning
@Borda Borda mentioned this pull request Jan 9, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @carmocca @akihironitta